Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: input file expand function impl #1646

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: input file expand function impl

@Peefy Peefy mentioned this pull request Sep 13, 2024
16 tasks
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10843838131

Details

  • 144 of 157 (91.72%) changed or added relevant lines in 7 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/entry.rs 45 47 95.74%
kclvm/runner/src/lib.rs 5 10 50.0%
kclvm/api/src/service/service_impl.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
kclvm/config/src/modfile.rs 4 92.02%
Totals Coverage Status
Change from base Build 10811048850: 0.03%
Covered Lines: 51199
Relevant Lines: 72548

💛 - Coveralls

@Peefy Peefy merged commit a00a1c6 into kcl-lang:main Sep 13, 2024
10 of 12 checks passed
@Peefy Peefy deleted the refactor-input-file-expand branch September 13, 2024 06:34
Peefy added a commit to Peefy/KCLVM that referenced this pull request Sep 14, 2024
Peefy added a commit to Peefy/KCLVM that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants