Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: program.pkg Module to Arc<Module> #1715

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 24, 2024

program.pkg HashMap<String, Vec> -> HashMap<String, Vec<Arc>> .
Reduce the performance loss of module ast clone

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

kclvm/evaluator/src/node.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11627602923

Details

  • 347 of 410 (84.63%) changed or added relevant lines in 29 files are covered.
  • 29 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 70.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runner/src/assembler.rs 0 1 0.0%
kclvm/api/src/service/service_impl.rs 0 4 0.0%
kclvm/runner/src/lib.rs 0 4 0.0%
kclvm/query/src/override.rs 0 8 0.0%
kclvm/sema/src/pre_process/config.rs 89 108 82.41%
kclvm/ast/src/ast.rs 36 63 57.14%
Files with Coverage Reduction New Missed Lines %
kclvm/parser/src/lib.rs 1 96.01%
kclvm/evaluator/src/lib.rs 1 86.96%
kclvm/sema/src/resolver/scope.rs 1 77.32%
kclvm/ast/src/ast.rs 3 69.98%
kclvm/sema/src/core/symbol.rs 3 53.58%
kclvm/sema/src/pre_process/config.rs 4 89.89%
kclvm/config/src/settings.rs 4 78.3%
kclvm/tools/src/LSP/src/state.rs 12 81.14%
Totals Coverage Status
Change from base Build 11591964791: 0.03%
Covered Lines: 52003
Relevant Lines: 73671

💛 - Coveralls

kclvm/evaluator/src/scope.rs Outdated Show resolved Hide resolved
kclvm/ast/src/ast.rs Outdated Show resolved Hide resolved
kclvm/ast/src/ast.rs Outdated Show resolved Hide resolved
kclvm/evaluator/src/module.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/namer/mod.rs Outdated Show resolved Hide resolved
kclvm/sema/src/pre_process/config.rs Outdated Show resolved Hide resolved
kclvm/sema/src/pre_process/config.rs Outdated Show resolved Hide resolved
@He1pa He1pa marked this pull request as ready for review November 1, 2024 03:24
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a6381df into kcl-lang:main Nov 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants