Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance hint. #1722

Merged
merged 1 commit into from
Oct 28, 2024
Merged

feat: enhance hint. #1722

merged 1 commit into from
Oct 28, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 28, 2024

  1. add more hint details for hint type and text_edit(double-click to insert).
  2. split hint from symbol.
  3. fix function call args hint

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  1. add more hint details for hint type and text_edit(double-click to insert).
  2. split hint from symbol.
  3. fix function call args hint
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…dit(double-click to insert). 2. split hint from symbol. 3. fix function call args hint

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa changed the title feat: enhance hint. … feat: enhance hint. Oct 28, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM.

@Peefy Peefy added the lsp label Oct 28, 2024
@Peefy Peefy merged commit 8302dcf into kcl-lang:main Oct 28, 2024
12 of 13 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11550170651

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 116 of 126 (92.06%) changed or added relevant lines in 5 files are covered.
  • 26 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/core/global_state.rs 9 11 81.82%
kclvm/sema/src/advanced_resolver/node.rs 71 79 89.87%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/advanced_resolver/node.rs 2 84.83%
kclvm/tools/src/LSP/src/state.rs 12 82.73%
kclvm/sema/src/core/symbol.rs 12 53.73%
Totals Coverage Status
Change from base Build 11547788230: 0.02%
Covered Lines: 51825
Relevant Lines: 73442

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The display of different expressions for the function inlay hint is inconsistent
3 participants