Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manifests yaml stream options impl #1724

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: manifests yaml stream options impl #1724

merged 1 commit into from
Oct 29, 2024
+100 −25

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1723

fix: manifests yaml stream options impl

@coveralls
Copy link
Collaborator

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11567214182

Details

  • 33 of 36 (91.67%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 70.547%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_json.rs 14 17 82.35%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/value/val_json.rs 1 82.89%
Totals Coverage Status
Change from base Build 11550534912: -0.02%
Covered Lines: 51819
Relevant Lines: 73453
💛 - Coveralls

He1pa
He1pa approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy merged commit 68a5dac into main Oct 29, 2024
13 checks passed
@Peefy Peefy deleted the fix-manifests-yaml-stream-opts-para branch October 29, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The ignore_private=False option does not work in the manifests.yaml_stream function
3 participants
@Peefy @coveralls @He1pa