Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix lsp parse cache. #1726

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: fix lsp parse cache. #1726

merged 2 commits into from
Oct 30, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 30, 2024

compile with vfs source code which not in main pkg

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Peefy
Peefy approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa changed the title fix: fix lsp parse cache. … fix: fix lsp parse cache. Oct 30, 2024
@He1pa He1pa force-pushed the fix_lsp_ast_cache branch 2 times, most recently from 1b6c38f to b46a214 Compare October 30, 2024 09:43
Peefy
Peefy approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa
fix ut
b28fff0 
Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11590874897

Details

  • 58 of 68 (85.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 70.568%
Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/parser/src/lib.rs 44 45 97.78%
kclvm/tools/src/LSP/src/compile.rs 14 23 60.87%
Totals Coverage Status
Change from base Build 11568239392: -0.002%
Covered Lines: 51855
Relevant Lines: 73482
💛 - Coveralls

@Peefy Peefy merged commit caa8d47 into kcl-lang:main Oct 30, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@He1pa @coveralls @Peefy