Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluator on the base schema order #1733

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: evaluator on the base schema order #1733

merged 1 commit into from
Nov 4, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: evaluator on the base schema order

fix #1730

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11658422860

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 70.583%
Files with Coverage Reduction New Missed Lines %
kclvm/evaluator/src/schema.rs 4 90.25%
Totals Coverage Status
Change from base Build 11657983745: 0.0%
Covered Lines: 52002
Relevant Lines: 73675
💛 - Coveralls

He1pa
He1pa approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 481eed9 into main Nov 4, 2024
13 checks passed
@Peefy Peefy deleted the fix-evaluator-schema-order branch November 4, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Computed base attribute fails to evaluate when sub-schema defined before base-schema
3 participants
@Peefy @coveralls @He1pa