Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance schema attr resolve for the double star expr #1743

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 6, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: enhance schema attr resolve for the double star expr

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11701059303

Details

  • 106 of 147 (72.11%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.583%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/var.rs 1 3 33.33%
kclvm/sema/src/resolver/ty.rs 12 19 63.16%
kclvm/sema/src/resolver/config.rs 93 125 74.4%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.1%
kclvm/tools/src/LSP/src/tests.rs 1 98.57%
kclvm/tools/src/LSP/src/compile.rs 1 80.17%
kclvm/sema/src/resolver/config.rs 2 80.48%
Totals Coverage Status
Change from base Build 11677384978: 0.02%
Covered Lines: 52086
Relevant Lines: 73794

💛 - Coveralls

@Peefy Peefy merged commit 841d614 into main Nov 6, 2024
11 of 13 checks passed
@Peefy Peefy deleted the enhance-schema-attr-resolve branch November 6, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants