Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp file watcher. #1744

Merged
merged 5 commits into from
Nov 8, 2024
Merged

feat: lsp file watcher. #1744

merged 5 commits into from
Nov 8, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 6, 2024

  1. Actively monitor file system changes. These changes will not be notified through lsp, e.g., execute kcl mod add xxx, kcl fmt xxx
  2. fix external pkg complete

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/*

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  1. Actively monitor file system changes. These changes will not be notified through lsp, e.g., execute kcl mod add xxx, kcl fmt xxx
  2. fix external pkg complete
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa marked this pull request as draft November 6, 2024 10:53
…hanges will not be notified through lsp, e.g., execute `kcl mod add xxx`, `kcl fmt xxx`

Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11721570179

Details

  • 280 of 320 (87.5%) changed or added relevant lines in 6 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 70.706%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/tests.rs 165 168 98.21%
kclvm/tools/src/LSP/src/state.rs 87 124 70.16%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 5 65.78%
kclvm/tools/src/LSP/src/state.rs 6 82.7%
kclvm/driver/src/lib.rs 7 83.49%
Totals Coverage Status
Change from base Build 11701909246: 0.1%
Covered Lines: 52377
Relevant Lines: 74077

💛 - Coveralls

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa marked this pull request as ready for review November 7, 2024 03:24
Signed-off-by: he1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa He1pa marked this pull request as draft November 7, 2024 06:45
@He1pa He1pa force-pushed the lsp_file_watcher branch 4 times, most recently from 055eea3 to 9f4d8d8 Compare November 7, 2024 10:04
Signed-off-by: he1pa <[email protected]>
@He1pa He1pa marked this pull request as ready for review November 7, 2024 12:19
@Peefy Peefy merged commit ddfd018 into main Nov 8, 2024
13 checks passed
@Peefy Peefy deleted the lsp_file_watcher branch November 8, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants