Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix complete schema pkg name error. #1750

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Nov 13, 2024

fix complete schema pkg name error.
And optimize the cursor position after completion

a = bbb.B{
    c: [ccc.C{}<cursor>]
}
->
a = bbb.B{
    c: [{<cursor>}]
}

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix complete schema pkg name error.
And optimize the cursor position after completion

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working lsp labels Nov 13, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11812982218

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 33 (84.85%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.687%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 28 33 84.85%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/tests.rs 1 98.54%
kclvm/tools/src/LSP/src/request.rs 2 65.78%
Totals Coverage Status
Change from base Build 11789673643: -0.02%
Covered Lines: 52369
Relevant Lines: 74086

💛 - Coveralls

@Peefy Peefy merged commit 257c0bf into main Nov 13, 2024
12 of 13 checks passed
@Peefy Peefy deleted the fix_schema_pkg_lsp_complete branch November 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants