Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance get schema type API with default value. #658

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #655
Close #653

feat: enhance get schema type API with default value and fix bool literal type string.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/api/src/service/ty.rs
  • kclvm/ast_pretty/src/lib.rs
  • kclvm/sema/src/resolver/global.rs
  • kclvm/sema/src/ty/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/testdata/get-schema-type-mapping.json
  • kclvm/api/src/testdata/get-schema-type-mapping.response.json

@Peefy Peefy added api Issues or PRs related to kcl rust native APIs and multi-lang APIs resolver labels Aug 14, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 14, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5855194763

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5807765205: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amyXia1994 amyXia1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peefy Peefy self-assigned this Aug 14, 2023
@Peefy Peefy merged commit 768073b into kcl-lang:main Aug 14, 2023
10 checks passed
@Peefy Peefy deleted the enhance-get-schema-ty-default-val branch August 14, 2023 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KclvmService.GetSchemaType API: wrong bool lit value KclvmService.GetSchemaType API: missing default value
4 participants