Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance config attribute type inference through the config attribute type map. #678

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 22, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #635

feat: enhance config attribute type inference through the config attribute type map.

metadata = {
    name = "app"
    labels.app = "app"
}
labels: {str:str} = metadata.labels

Before this PR, the type of metadata.labels will be inferred as a {str:str}|str type. In fact, we can derive more precise types, and this PR solves this problem. The more information is in #635

2. What is the scope of this PR (e.g. component or file name):

The kcl sematic model crate

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/union_ty/union_ty_11/main.k
  • test/grammar/types/union_ty/union_ty_12/main.k

@Peefy Peefy added type-system Issues or PRs related to kcl type system resolver labels Aug 22, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 7f51ede into kcl-lang:main Aug 23, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@Peefy Peefy deleted the enhance-config-attr-ty-infer branch August 23, 2023 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolver type-system Issues or PRs related to kcl type system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants