Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp find_def for dict type #683

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

Close #635

2. What is the scope of this PR (e.g. component or file name):

  • lsp
  • sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Enhance find_def in lsp for dict type, used for lsp goto def and hover

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Aug 25, 2023

Pull Request Test Coverage Report for Build 5973332352

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5963521174: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy added the lsp label Aug 25, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 25, 2023
@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Aug 25, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 34b7fb6 into kcl-lang:main Aug 28, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCL Semantic model issues for config attribute
3 participants