Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix ConfigEntry and ConfigIfEntry expr position err #687

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 30, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

parser
resolver
lsp

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix some position err about ConfigEntry and ConfigIfEntry
#524

items = [item | {
   # If all annotations are matched, patch more annotations
    if all key, value in toMatch {
        item.metadata.annotations[key] == value
    }:
       metadata.annotations: toAdd
} for item in option("items")]


capabilities = option("params").capabilities or ["SETUID", "SETFCAP"]
items1 = [item | {
    if item.kind == "Pod":
        spec.containers: [{
            "securityContext": {"capabilities": {"add" += [cc] if cc not in (container?.securityContext?.capabilities?.drop or []) else [] for cc in capabilities}}
        } for container in item.spec.containers]
} for item in option("items")]
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added parser Issues or PRs related to kcl parser semantic Issues or PRs related to kcl semantic and checker resolver lsp labels Aug 30, 2023
@He1pa He1pa self-assigned this Aug 30, 2023
@He1pa He1pa mentioned this pull request Aug 24, 2023
10 tasks
@He1pa He1pa force-pushed the bugfix_config_and_configIf_expr_pos branch from 9603f80 to 481584b Compare August 30, 2023 06:11
@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2023

Pull Request Test Coverage Report for Build 6021589404

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 6011247465: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit be2ace4 into kcl-lang:main Aug 30, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp parser Issues or PRs related to kcl parser resolver semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants