Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove unique check in unification stmt #725

Merged
merged 1 commit into from
Sep 20, 2023
Merged

feat: remove unique check in unification stmt #725

merged 1 commit into from
Sep 20, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 20, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

sema

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Remove incorrect semantic checks

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy added this to the v0.7.0 Release milestone Sep 20, 2023
@Peefy Peefy added the resolver label Sep 20, 2023
Peefy
Peefy approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 28ce996 into kcl-lang:main Sep 20, 2023
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Peefy Peefy Peefy approved these changes

Assignees
No one assigned
Labels
resolver
Projects
None yet
Milestone
v0.7.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@He1pa @Peefy