Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code clean-unused imports and comments #761

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Oct 13, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

unused imports:

  • kclvm/sema/src/resolver/global.rs
  • kclvm/tools/src/LSP/src/main.rs

unused comments:

  • kclvm/tools/src/LSP/src/find_refs.rs
  • kclvm/tools/src/LSP/src/notification.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

This PR clean unused imports and comments.

image
image

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 marked this pull request as ready for review October 13, 2023 03:21
@amyXia1994 amyXia1994 requested a review from Peefy October 13, 2023 03:23
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 13, 2023
@coveralls
Copy link
Collaborator

coveralls commented Oct 13, 2023

Pull Request Test Coverage Report for Build 6503622631

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 6495361724: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 61a6640 into kcl-lang:main Oct 13, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@amyXia1994 amyXia1994 deleted the chore/code-clean branch October 13, 2023 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants