Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goto attr def from attr def itself, add test cases on goto-def and find-refs #765

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

close #754
It turns out the the find refs failed from the schema attribute def, is caused because the goto-def ignored the case when goto-def from schema attr def. Thanks to @He1pa we fixed the bug and added more tests on it.

2. What is the scope of this PR (e.g. component or file name):

  • the fix:
    • kclvm/tools/src/LSP/src/util.rs
  • the tests:
    • kclvm/tools/src/LSP/src/find_refs.rs
    • kclvm/tools/src/LSP/src/goto_def.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Fix goto attr def from attr def itself, add test cases on goto-def and find-refs

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@amyXia1994 amyXia1994 requested a review from Peefy October 13, 2023 09:54
@amyXia1994 amyXia1994 marked this pull request as ready for review October 13, 2023 09:54
@Peefy Peefy added tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. lsp labels Oct 13, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 13, 2023
@Peefy Peefy added the bug Something isn't working label Oct 13, 2023
Signed-off-by: xiarui.xr <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6506951355

  • 61 of 62 (98.39%) changed or added relevant lines in 3 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-16.8%) to 71.265%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/find_refs.rs 44 45 97.78%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 6505829489: -16.8%
Covered Lines: 36308
Relevant Lines: 50948

💛 - Coveralls

@Peefy Peefy merged commit cabe3bf into kcl-lang:main Oct 13, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@amyXia1994 amyXia1994 deleted the fix/attribute-def branch October 16, 2023 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug fix] find reference on schema attribute failed
3 participants