Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add full type string for function type #771

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix: add full type string for function type #771

merged 2 commits into from
Oct 16, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Fixed #770

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/ty/mod.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added bug Something isn't working error-handling Issues or PRs related to kcl error handling labels Oct 16, 2023
@zong-zhe zong-zhe added this to the v0.7.0 Release milestone Oct 16, 2023
@zong-zhe zong-zhe requested review from i-zhen and Peefy October 16, 2023 09:20
@zong-zhe zong-zhe self-assigned this Oct 16, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 83cc443 into kcl-lang:main Oct 16, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working error-handling Issues or PRs related to kcl error handling
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

bug: the diagnostic of a lambda expression type error is incomplete
2 participants