Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename symbol #773

Merged
merged 4 commits into from
Oct 17, 2023
Merged

feat: rename symbol #773

merged 4 commits into from
Oct 17, 2023

Conversation

amyXia1994
Copy link
Contributor

@amyXia1994 amyXia1994 commented Oct 16, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

close #766

2. What is the scope of this PR (e.g. component or file name):

add rename feat:

kclvm/tools/src/LSP/src/capabilities.rs
kclvm/tools/src/LSP/src/find_refs.rs
kclvm/tools/src/LSP/src/goto_def.rs
kclvm/tools/src/LSP/src/request.rs
kclvm/tools/src/LSP/src/to_lsp.rs

add tests:
kclvm/tools/src/LSP/src/test_data/rename_test/main.k
kclvm/tools/src/LSP/src/test_data/rename_test/pkg/vars.k
kclvm/tools/src/LSP/src/tests.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

support rename symbol

rename

when the new name is invalid:

rename2

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: xiarui.xr <[email protected]>
@Peefy Peefy added feat tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. lsp labels Oct 16, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 16, 2023
@amyXia1994 amyXia1994 requested a review from He1pa October 16, 2023 14:31
@amyXia1994 amyXia1994 marked this pull request as ready for review October 17, 2023 02:38
kclvm/tools/src/LSP/src/to_lsp.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/request.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/find_refs.rs Outdated Show resolved Hide resolved
Signed-off-by: xiarui.xr <[email protected]>
Signed-off-by: xiarui.xr <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Oct 17, 2023

Pull Request Test Coverage Report for Build 6543240509

  • 194 of 216 (89.81%) changed or added relevant lines in 7 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.2%) to 70.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/capabilities.rs 0 1 0.0%
kclvm/tools/src/LSP/src/request.rs 52 62 83.87%
kclvm/tools/src/LSP/src/find_refs.rs 33 44 75.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6533686227: -17.2%
Covered Lines: 36512
Relevant Lines: 51715

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 4486c08 into kcl-lang:main Oct 17, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@amyXia1994 amyXia1994 deleted the feat/rename branch October 17, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat lsp tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Feature] support rename symbols
3 participants