Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: lsp crash caused by vfs loader #778

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Oct 17, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

tools/LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

lsp crash when close file.
The reason is that the receiver of vfs is dropped when creating a new LanguageServerState. When the file is closed, there is no object to accept the Message, causing panic.

image

ref: https://github.com/rust-lang/rust-analyzer/blob/d6afb4fa239fe7b5b34e5cefa9e58148fdff65b8/crates/rust-analyzer/src/global_state.rs#L148

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working lsp labels Oct 17, 2023
@He1pa He1pa added this to the v0.7.0 Release milestone Oct 17, 2023
@He1pa He1pa self-assigned this Oct 17, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6542986775

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6533686227: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6543071638

  • 53 of 54 (98.15%) changed or added relevant lines in 3 files are covered.
  • 471 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-17.2%) to 70.582%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/notification.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/diagnostic/diagnostic_message.rs 74 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 170 0.0%
Totals Coverage Status
Change from base Build 6533686227: -17.2%
Covered Lines: 36423
Relevant Lines: 51604

💛 - Coveralls

@He1pa He1pa merged commit 6e02ee7 into kcl-lang:main Oct 17, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Bugfix] Language Server sometimes crashes and won't restart automatically
3 participants