Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign stmt in schema codegen and runtime value merge. #787

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Oct 18, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #785

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs
  • kclvm/runtime/src/value/val_schema.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/assign_stmt/assign_stmt_0/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_1/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_2/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_3/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_4/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_5/main.k
  • test/grammar/schema/assign_stmt/assign_stmt_6/main.k
  • test/grammar/schema/optional_attr/inherit_2/main.k
  • test/grammar/schema/optional_attr/inherit_3/main.k
  • test/grammar/schema/init/init_nested_schema_1/main.k

@Peefy Peefy added bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions resolver labels Oct 18, 2023
@Peefy Peefy added this to the v0.7.0 Release milestone Oct 18, 2023
@Peefy Peefy self-assigned this Oct 18, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6556537794

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.82%

Totals Coverage Status
Change from base Build 6546481370: 0.0%
Covered Lines: 2300
Relevant Lines: 2619

💛 - Coveralls

@Peefy Peefy merged commit 630cf64 into kcl-lang:main Oct 18, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
No open projects
Status: v0.7.0 Release Done
Development

Successfully merging this pull request may close these issues.

[Bug] Multi-level inheritance is not working
2 participants