Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong dot and assign complete after special ty #946

Closed
wants to merge 1 commit into from

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Dec 6, 2023

fix issues about wrong complete after str ty.

a = "1"
# a.   // wrong complete str builtin functions 

schema A:
    a: str
   check:   // wrong complete str builtin functions

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

lsp/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Dec 6, 2023

Pull Request Test Coverage Report for Build 7112991819

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7112634044: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@He1pa He1pa closed this Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@Peefy
Copy link
Contributor

Peefy commented Dec 6, 2023

I think the fundamental reason for this issue is to complete the content through the current symbol query. In fact, it is necessary to enhance the semantic model within the compiler, e.g., build expression symbols, and query expression symbols instead of adding a trick function option in the LSP crate. cc @He1pa @NeverRaR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants