-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lsp semantic tokens provider #968
Conversation
@CodiumAI-Agent /review |
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and the changes are logically grouped. The addition of semantic tokens provider is a valuable enhancement for the KCL language's LSP. It would be beneficial to include more comments in the code to explain the logic and functionality of the new feature. 🤖 Code feedback:
✨ Usage tips:
|
aea36e0
to
601e28e
Compare
Pull Request Test Coverage Report for Build 7346371503
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7382719301
💛 - Coveralls |
601e28e
to
d79db3c
Compare
…itor Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
d79db3c
to
0c33d0d
Compare
Signed-off-by: he1pa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lsp semantic tokens provider, i.e., semantic highlighting in editor
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
lsp
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: