Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRETEST1]: Initial changes for adding support to clone bare repo #400

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Manoramsharma
Copy link
Contributor

@Manoramsharma Manoramsharma commented Jul 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #384

2. What is the scope of this PR (e.g. component or file name):

pkg/git/git.go
pkg/git/git_test.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

This PR is an initial step to add ability of current git module of kpm to support bare repository clone feature. Currently I am not sure about the packages/ dependencies that need to be cloned as bare or not-bare repositories just tried extend pkg/git/git.go

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

The current changes lead to failure of NewCloneOptions functions across the cmd package because I need guidance on changing the value of isBare flag as its now been added as a new cloning option.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

github-actions bot commented Jul 26, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Manoramsharma
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request Jul 26, 2024
pkg/git/git.go Outdated Show resolved Hide resolved
Signed-off-by: Manoramsharma <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10112491851

Details

  • 5 of 19 (26.32%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 39.805%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/git/git.go 5 19 26.32%
Files with Coverage Reduction New Missed Lines %
pkg/git/git.go 1 44.77%
Totals Coverage Status
Change from base Build 10058151265: -0.04%
Covered Lines: 3061
Relevant Lines: 7690

💛 - Coveralls

@Peefy Peefy merged commit 5145a44 into kcl-lang:main Jul 26, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants