feat: unified dependency system #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: utnim2 <[email protected]>
|
@Peefy can i get a review of the work done so far in this PR |
|
cc @zong-zhe Could you help review it? |
Peefy
reviewed
Aug 1, 2024
| @@ -67,11 +68,14 @@ func NewKpmClient() (*KpmClient, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| ds := unified.NewDependencySystem() | |||
| credsClient *CredClient | ||
| CredsClient CredentialClient | ||
| // Platform is the platform for OCI downloads | ||
| Platform string |
There was a problem hiding this comment.
Cloud you please use a Platform type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
Refer to #384
2. What is the scope of this PR (e.g. component or file name):
pkg/unified/dependency.go
pkg/downloader/downloader.go
pkg/cmd/client.go
Some modification are still needed to be done
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Added a unified dependency system i
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
No(TODO)