Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFX-Pretest]: Implemented local git command to support downloading from the bare repo #416

Closed
wants to merge 4 commits into from

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Related to #384

pkg/git/git.go
pkg/git/git_test.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

implemented local git command to support downloading from the bare repo repository, and updated the cloneBare method to be private

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

image
image

added a specific test for cloneBare method

@Gmin2 Gmin2 changed the title [LFX-Pretes]: Implemented local git command to support downloading from the bare repo [LFX-Pretest]: Implemented local git command to support downloading from the bare repo Jul 30, 2024
@Gmin2
Copy link
Contributor Author

Gmin2 commented Jul 30, 2024

Hey @zong-zhe and @Peefy

idk,why build is failing in github actions, it is working fine locally

@zong-zhe
Copy link
Contributor

Hey @zong-zhe and @Peefy

idk,why build is failing in github actions, it is working fine locally

Try make build to make sure your code can pass the compilation.

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jul 30, 2024

Try make build to make sure your code can pass the compilation.

it is working fine, as mentioned in the above comment,
image
cc @zong-zhe

@Gmin2 Gmin2 closed this Jul 30, 2024
@Gmin2
Copy link
Contributor Author

Gmin2 commented Jul 30, 2024

Continued in #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
2 participants