-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Support dashed - generation. #95
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1bf9fbe
to
819f390
Compare
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: SAP [email protected]
ff918d9
to
472bbd5
Compare
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: SAP [email protected]
472bbd5
to
ed7ee37
Compare
@mjudeikis: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
replaced by #97 |
Summary
We don't honor
groupGoName
andPacakgeName
in our generator (different bug somewhere). So when generating clients for things likekube-bind.io
this gets crazy. This is hack, and we should fix this properly. But as-
values are not supported either way in aliasing and methodNames, I don't feel that bad doing this hack.If this works (gonna test and update this message), I propose we merge and create a follow-up issue to get to the bottom of where we lose marker value :/ This is ka inda stop-gap solution for now.
Related issue(s)
Fixes #
Release Notes