Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Support dashed - generation. #95

Closed

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Dec 8, 2024

Summary

We don't honor groupGoName and PacakgeName in our generator (different bug somewhere). So when generating clients for things like kube-bind.io this gets crazy. This is hack, and we should fix this properly. But as - values are not supported either way in aliasing and methodNames, I don't feel that bad doing this hack.

If this works (gonna test and update this message), I propose we merge and create a follow-up issue to get to the bottom of where we lose marker value :/ This is ka inda stop-gap solution for now.

Related issue(s)

Fixes #

Release Notes

HACK: Fix `-` dashed package generation by force replace `-` 

@kcp-ci-bot kcp-ci-bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Dec 8, 2024
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mjudeikis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2024
@mjudeikis mjudeikis marked this pull request as draft December 8, 2024 12:53
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2024
@mjudeikis mjudeikis force-pushed the mjudeikis/hack.dashed.packages branch 2 times, most recently from 1bf9fbe to 819f390 Compare December 8, 2024 20:43
Signed-off-by: Mangirdas Judeikis <[email protected]>
On-behalf-of: SAP [email protected]
@mjudeikis mjudeikis force-pushed the mjudeikis/hack.dashed.packages branch from ff918d9 to 472bbd5 Compare December 12, 2024 15:32
@mjudeikis mjudeikis marked this pull request as ready for review December 12, 2024 15:32
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@mjudeikis mjudeikis force-pushed the mjudeikis/hack.dashed.packages branch from 472bbd5 to ed7ee37 Compare December 12, 2024 15:41
@kcp-ci-bot
Copy link
Contributor

@mjudeikis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-code-generator-test e56c97e link true /test pull-code-generator-test
pull-code-generator-lint e56c97e link true /test pull-code-generator-lint
pull-code-generator-verify e56c97e link true /test pull-code-generator-verify

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mjudeikis
Copy link
Contributor Author

replaced by #97

@mjudeikis mjudeikis closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants