Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: :feature: PoC: global service accounts without warrants #3261

Closed

Conversation

sttts
Copy link
Member

@sttts sttts commented Jan 22, 2025

Summary

With #3260 service account can act anonymously in other logical clusters. This PR now adds rule resolver support for the global service account name system:kcp:serviceaccount:cluster:ns:name. With that "magically" you can bind RBAC roles against it.

Related issue(s)

Fixes #

Release Notes

Make Kube service accounts act as `system:kcp:serviceaccount:cluster:ns:name` in additional to their normal user name `system:serviceaccount:ns:name`.

sttts added 2 commits January 22, 2025 14:42
…cting as anonymous+authenticated

Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 22, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sttts. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2025
sttts added 2 commits January 22, 2025 18:18
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-global-serviceaccounts-without-warrants branch from 2f2139e to 39d829d Compare January 22, 2025 17:18
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Jan 22, 2025

@sttts: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-verify 39d829d link true /test pull-kcp-verify
pull-kcp-test-e2e-sharded 39d829d link true /test pull-kcp-test-e2e-sharded

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
@kcp-ci-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Member Author

sttts commented Jan 27, 2025

/close

@kcp-ci-bot kcp-ci-bot closed this Jan 27, 2025
@kcp-ci-bot
Copy link
Contributor

@sttts: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants