🐛 Correctly check original groups against system:masters in scope filter
#3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
embik
force-pushed
the
impersonation-gatekeeper
branch
from
c6fd133 to
5ea1c47
Compare
kcp-ci-bot
added
size/M
|
/lgtm |
|
LGTM label has been added. Git tree hash: 3a320cf9e326e7e14c51c2dd26e45e2d0be154ee
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
/hold just ... checking some things. |
kcp-ci-bot
added
the
do-not-merge/hold
|
/retest |
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
impersonation-gatekeeper
branch
from
5ea1c47 to
222d1ca
Compare
kcp-ci-bot
added
size/L
|
/hold cancel |
kcp-ci-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
LGTM label has been added. Git tree hash: c45562224102853cff8bdcb68b3b2f72d2cd0f09
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We discovered that the
WithImpersonationScopingfilter had a flaw: It was checking the already impersonated user identity to determine whether adding a scope should be skipped forsystem:mastersimpersonators. But this check needs to run against the original user identity, not the impersonated identity (since that will never includesystem:masters).This PR stores the user identity during
WithImpersonationGatekeeperin the request context to fetch it at a later stage inWithImpersonationScoping.As a bonus, I discovered that the check for extra impersonation headers is not correct: It was checking the HTTP header values, but it should be checking the name/key of the header. So the list of extra impersonations was always empty. The tests didn't check this.
Related issue(s)
Fixes #
Release Notes