Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e: add SelfSubjectRulesReview test #3268

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

sttts
Copy link
Member

@sttts sttts commented Jan 24, 2025

Summary

Adding an e2e test for SelfSubjectRulesReview for scoping.

Needs #3269.

Related issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@sttts sttts force-pushed the sttts-selfsubjectrules-e2e branch from f5f6c7a to ff8b81f Compare January 24, 2025 10:36
@sttts
Copy link
Member Author

sttts commented Jan 24, 2025

/retest

@sttts sttts force-pushed the sttts-selfsubjectrules-e2e branch 3 times, most recently from 408f06d to d6dcaaa Compare January 24, 2025 11:55
@sttts
Copy link
Member Author

sttts commented Jan 24, 2025

/retest

@sttts sttts force-pushed the sttts-selfsubjectrules-e2e branch from d6dcaaa to bcfbbd7 Compare January 25, 2025 13:39
@kcp-ci-bot kcp-ci-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2025
@sttts sttts force-pushed the sttts-selfsubjectrules-e2e branch from bcfbbd7 to 3dace42 Compare January 25, 2025 13:41
Signed-off-by: Dr. Stefan Schimanski <[email protected]>
@sttts sttts force-pushed the sttts-selfsubjectrules-e2e branch from 3dace42 to 45f1c8a Compare January 25, 2025 14:50
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 25, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b45ab9a27f7bba3dcbab32b4a5d439055e2a8fb0

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2025
@embik
Copy link
Member

embik commented Jan 25, 2025

/retest

@kcp-ci-bot kcp-ci-bot merged commit a5f4c98 into kcp-dev:main Jan 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants