Skip to content

Fix errors in the build-image action #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2025
Merged

Fix errors in the build-image action #4

merged 3 commits into from
Oct 1, 2025

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 1, 2025 •
edited
Loading

Follow up on #3 to fix a couple of errors:

  • Fix a path name for triggering the action run on PRs
  • Add a checkout step to make sure the repository is cloned
  • Add a build step as the image build process requires binaries to be already present
  • Remove non-existing toLower function (our org and repository names are anyways lower cases)
  • All GitHub Actions specified in uses are now pinned to SHAs

/assign @xrstf @embik

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Oct 1, 2025

/hold

@kcp-ci-bot kcp-ci-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@xmudrii
Copy link
Member Author

xmudrii commented Oct 1, 2025

/hold cancel

@kcp-ci-bot kcp-ci-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@kcp-ci-bot kcp-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2025
@xmudrii xmudrii changed the title Drop non-existing function from build-image action Fix errors in the build-image action Oct 1, 2025
@xmudrii
Pin GitHub Actions to SHAs
7315c51 
On-behalf-of: @SAP [email protected]
Signed-off-by: Marko Mudrinić <[email protected]>
embik
embik approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: 47b433e2374132f646329a9699e1189d9ac0704d

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@kcp-ci-bot kcp-ci-bot merged commit 1677611 into kcp-dev:master Oct 1, 2025
7 checks passed
@xmudrii xmudrii deleted the fix-build-image branch October 1, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@xrstf xrstf

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xmudrii @kcp-ci-bot @embik @xrstf