Fix undefined offset: 1 in "gitRepository" action when GIT repository…

… is empty
keboola · Jan 9, 2023 · f99045c · f99045c
1 parent 20466bd
commit f99045c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Service/GitRepositoryService.php b/src/Service/GitRepositoryService.php
@@ -82,7 +82,12 @@ public function listRemoteBranches(string $projectPath): array
         ];
         $process = new Process($args, $projectPath);
         $process->mustRun();
-        $branches = (array) explode("\n", trim($process->getOutput()));
+
+        if (trim($process->getOutput()) !== '') {
+            $branches = (array) explode("\n", trim($process->getOutput()));
+        } else {
+            return [];
+        }
 
         return array_map(function ($item) {
             [$branchRaw, $comment, $sha, $author, $email, $date] = explode(',', $item);

diff --git a/tests/phpunit/Service/GitRepositoryServiceTest.php b/tests/phpunit/Service/GitRepositoryServiceTest.php
@@ -69,6 +69,16 @@ public function testClonePrivateRepository(string $url, string $username, string
         $this->assertTrue(true);
     }
 
+    public function testListBranchesEmptyGitProject(): void
+    {
+        $gitService = new GitRepositoryService($this->dataDir);
+        $gitService->clone('https://github.com/keboola/empty-repo-test.git');
+        $branches = $gitService->listRemoteBranches($this->dataDir . '/dbt-project');
+
+        self::assertIsArray($branches);
+        self::assertEmpty($branches);
+    }
+
     /**
      * @dataProvider privateRepositoryInvalidCredentials
      */