Merge pull request #23 from keboola/adamvyborny-CM-646-handle-field-c…

…annot-start-exception Handle field names may not start with $ as user exception
keboola · Aug 25, 2023 · bce23e0 · bce23e0
2 parents 2ad8c33 + 9690100
commit bce23e0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Export.php b/src/Export.php
@@ -137,6 +137,10 @@ protected function handleMongoExportFails(Throwable $e): void
             throw new UserException('$sort key ordering must be 1 (for ascending) or -1 (for descending)');
         }
 
+        if (str_contains($e->getMessage(), 'FieldPath field names may not start with \'$\'')) {
+            throw new UserException('FieldPath field names may not start with \'$\'');
+        }
+
         if (preg_match('/(Failed:.*?command)/s', $e->getMessage(), $matches)) {
             if (isset($matches[1])) {
                 throw new UserException(trim($matches[1]));

diff --git a/tests/phpunit/HandleMongoExportFailsTest.php b/tests/phpunit/HandleMongoExportFailsTest.php
@@ -79,6 +79,14 @@ public function exceptionsProvider(): Generator
             new UserException('Failed: (Unauthorized) not authorized on slotManagementDBTest to ' .
                 'execute command'),
         ];
+
+        yield 'field names may not start with $' => [
+            new ProcessFailedException($this->createMockInstanceOfProcess('2023-05-17T12:49:22.079+0000\t' .
+                'connected to: mongodb+srv://[**REDACTED**]@cl-shared-all-prod-web.x0u5m.mongodb.net/slotManagementDB' .
+                '2023-05-17T12:49:22.238+0000\tFailed: (Location16410) FieldPath field names may not start with \'$\'' .
+                'Consider using $getField or $setField.')),
+            new UserException('FieldPath field names may not start with \'$\''),
+        ];
     }
 
     private function createMockInstanceOfProcess(string $errorOutput): Process