Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test fix take two #8

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

rosteen
Copy link

@rosteen rosteen commented Mar 28, 2024

Today is just the worst ๐Ÿ˜ฎโ€๐Ÿ’จ - can't reopen after force pushing, apparently, and I opened this vs main the first time instead of this branch. I still need to make sure taking _adjust_limits_aspect out of the delay block doesn't break anything in the UI.

Supersedes #7 and #6

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

โ— No coverage uploaded for pull request base (3.9-updates@964e8cd). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             3.9-updates       #8   +/-   ##
==============================================
  Coverage               ?   94.50%           
==============================================
  Files                  ?       37           
  Lines                  ?     1582           
  Branches               ?        0           
==============================================
  Hits                   ?     1495           
  Misses                 ?       87           
  Partials               ?        0           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@kecnry
Copy link
Owner

kecnry commented Mar 28, 2024

@astrofrog - we needed to make this change in scatter viewers in order to be compatible with changes introduced in spacetelescope/jdaviz#2649 (see spacetelescope#92). Any idea if that is something incompatible with scatter viewers in glue or if this is a reasonable solution?

Copy link
Owner

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this for now since it passes tests and if there is a more elegant (or upstream) fix down the road, we can always revert. Thanks again for tracking this one down!

@kecnry kecnry merged commit ee0ebab into kecnry:3.9-updates Mar 28, 2024
10 checks passed
kecnry pushed a commit that referenced this pull request Mar 28, 2024
* Fix failing dev test by using lim_helpers
* Make equivalent change in reset_limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants