[WIP] interceptor: support for HTTP header routing #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wozniakjan
force-pushed
the
interceptor/header_based_routing
branch
5 times, most recently
from
8fa1e77 to
41ce412
Compare
Signed-off-by: Jan Wozniak <[email protected]>
wozniakjan
force-pushed
the
interceptor/header_based_routing
branch
from
41ce412 to
199b19a
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for HTTP header routing in the interceptor, refactoring the tableMemory implementation and related utilities to leverage header-based matching.
- Introduces a new RouteWithHeaders method to route based on HTTP header values.
- Refactors tableMemory, httpSOIndex, and httpSOStore to support the new routing behavior.
- Updates tests and CRD definitions to accommodate the header-based routing changes.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/routing/tablememory_test.go | Updated tests to use the new helper (newTableMemory) and adjusted assertions for header routing behavior. |
| pkg/routing/tablememory.go | Refactored tableMemory implementation and added the RouteWithHeaders method for header-based routing. |
| pkg/routing/table.go | Updated routing logic to leverage RouteWithHeaders using the request headers. |
| pkg/routing/httpso_store_test.go | Added tests to cover new and updated behaviors of httpSOStore. |
| pkg/routing/httpso_store.go | Implemented helper functions for managing HTTPScaledObject lists with header considerations. |
| pkg/routing/httpso_index_test.go | Updated tests for httpSOIndex functionality with inserted and deleted values. |
| pkg/routing/httpso_index.go | Added helper functions for httpSOIndex to manage the index tree for HTTPScaledObject routing. |
| operator/apis/http/v1alpha1/httpscaledobject_types.go | Added the new Header struct for header matching and updated CRD definitions accordingly. |
| config/crd/bases/http.keda.sh_httpscaledobjects.yaml | Updated CRD documentation to include the new headers field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip, credits to #1222
Checklist
README.mddocs/directoryFixes #1177