Feat/configurable server timeouts #1310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces configurable server-side timeouts for the HTTP interceptor proxy. The following timeouts can now be set via environment variables: - KEDA_HTTP_SERVER_READ_TIMEOUT: Sets the ReadTimeout for the proxy server. - KEDA_HTTP_SERVER_WRITE_TIMEOUT: Sets the WriteTimeout for the proxy server. - KEDA_HTTP_SERVER_IDLE_TIMEOUT: Sets the IdleTimeout for the proxy server. These timeouts provide more granular control over the connection behavior between clients and the interceptor, allowing for longer timeout capabilities as you requested. The default for these timeouts is "0s", which means: - For ReadTimeout: No timeout. - For WriteTimeout: No timeout. - For IdleTimeout: Go's default http.Server behavior (uses TCP keep-alives). Validation has been added to ensure these timeout values cannot be negative.
Signed-off-by: bazooka720 <[email protected]>
wozniakjan
approved these changes
Jun 20, 2025
Comment on lines
+38
to
+42
| ServerReadTimeout time.Duration `envconfig:"KEDA_HTTP_SERVER_READ_TIMEOUT" default:"120s"` | ||
| // ServerWriteTimeout is the maximum duration before timing out writes of the response. | ||
| ServerWriteTimeout time.Duration `envconfig:"KEDA_HTTP_SERVER_WRITE_TIMEOUT" default:"120s"` | ||
| // ServerIdleTimeout is the maximum amount of time to wait for the next request when keep-alives are enabled. | ||
| ServerIdleTimeout time.Duration `envconfig:"KEDA_HTTP_SERVER_IDLE_TIMEOUT" default:"120s"` |
There was a problem hiding this comment.
Can we make the defaults be 0? That way, the default behaviour remains the same and it won't be a potentially breaking change.
wozniakjan
requested changes
Jun 20, 2025
There was a problem hiding this comment.
hmm, looks like this actually doesn't compile, there are some function calls affected by this change
interceptor/forward_wait_func.go:1: : # github.com/kedacore/http-add-on/interceptor [github.com/kedacore/http-add-on/interceptor.test]
Error: interceptor/main.go:256:55: not enough arguments in call to kedahttp.ServeContext
have (context.Context, string, *"net/http".ServeMux, nil)
want (context.Context, string, "net/http".Handler, *tls.Config, *"github.com/kedacore/http-add-on/interceptor/config".Timeouts)
Error: interceptor/main.go:266:62: not enough arguments in call to kedahttp.ServeContext
have (context.Context, string, "net/http".Handler, nil)
want (context.Context, string, "net/http".Handler, *tls.Config, *"github.com/kedacore/http-add-on/interceptor/config".Timeouts) (typecheck)
package main
pkg/http/server.go:1: : # github.com/kedacore/http-add-on/pkg/http [github.com/kedacore/http-add-on/pkg/http.test]
Error: pkg/http/server_test.go:33:38: not enough arguments in call to ServeContext
have (context.Context, string, "net/http".HandlerFunc, nil)
want (context.Context, string, "net/http".Handler, *tls.Config, *config.Timeouts)
Error: pkg/http/server_test.go:67:38: not enough arguments in call to ServeContext
have (context.Context, string, "net/http".HandlerFunc, *tls.Config)
want (context.Context, string, "net/http".Handler, *tls.Config, *config.Timeouts) (typecheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
README.mddocs/directoryFixes #