Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve path prefix e2e test #845

Merged
merged 1 commit into from
Nov 27, 2023
Merged

chore: Improve path prefix e2e test #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 127 additions & 32 deletions tests/checks/path_prefix/path_prefix_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package path_prefix_test

import (
"fmt"
"sync"
"testing"

"github.com/tj/assert"
Expand All @@ -20,13 +21,15 @@ const (
var (
testNamespace = fmt.Sprintf("%s-ns", testName)
deploymentName = fmt.Sprintf("%s-deployment", testName)
deploymentName2 = fmt.Sprintf("%s-deployment-2", testName)
serviceName = fmt.Sprintf("%s-service", testName)
httpScaledObjectName = fmt.Sprintf("%s-http-so", testName)
host = testName
pathPrefix0 = "/123/456"
notPathPrefix0 = "/123/4567"
pathPrefix1 = "/qwe/rty"
notPathPrefix1 = "/qwe/rt"
pathPrefix2 = "/qwe/oty"
minReplicaCount = 0
maxReplicaCount = 1
)
Expand All @@ -40,6 +43,7 @@ type templateData struct {
PathPrefix string
PathPrefix0 string
PathPrefix1 string
PathPrefix2 string
MinReplicas int
MaxReplicas int
}
Expand Down Expand Up @@ -96,46 +100,118 @@ spec:
port: http
`

loadJobTemplate = `
apiVersion: batch/v1
kind: Job
httpScaledObjectTemplate = `
kind: HTTPScaledObject
apiVersion: http.keda.sh/v1alpha1
metadata:
name: generate-request
name: {{.HTTPScaledObjectName}}
namespace: {{.TestNamespace}}
spec:
host: {{.Host}}
pathPrefixes:
- {{.PathPrefix0}}
- {{.PathPrefix1}}
targetPendingRequests: 100
scaledownPeriod: 10
scaleTargetRef:
deployment: {{.DeploymentName}}
service: {{.ServiceName}}
port: 8080
replicas:
min: {{ .MinReplicas }}
max: {{ .MaxReplicas }}
`

serviceTemplate2 = `
apiVersion: v1
kind: Service
metadata:
name: {{.ServiceName}}-2
namespace: {{.TestNamespace}}
labels:
app: {{.DeploymentName}}-2
spec:
ports:
- port: 8080
targetPort: http
protocol: TCP
name: http
selector:
app: {{.DeploymentName}}-2
`

deploymentTemplate2 = `
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{.DeploymentName}}-2
namespace: {{.TestNamespace}}
labels:
app: {{.DeploymentName}}-2
spec:
replicas: 0
selector:
matchLabels:
app: {{.DeploymentName}}-2
template:
metadata:
labels:
app: {{.DeploymentName}}-2
spec:
containers:
- name: curl-client
image: curlimages/curl
imagePullPolicy: Always
command: ["curl", "-H", "Host: {{.Host}}", "keda-http-add-on-interceptor-proxy.keda:8080{{.PathPrefix}}"]
restartPolicy: Never
activeDeadlineSeconds: 600
backoffLimit: 5
- name: {{.DeploymentName}}
image: registry.k8s.io/e2e-test-images/agnhost:2.45
args:
- netexec
ports:
- name: http
containerPort: 8080
protocol: TCP
readinessProbe:
httpGet:
path: /
port: http
`

httpScaledObjectTemplate = `
httpScaledObjectTemplate2 = `
kind: HTTPScaledObject
apiVersion: http.keda.sh/v1alpha1
metadata:
name: {{.HTTPScaledObjectName}}
name: {{.HTTPScaledObjectName}}-2
namespace: {{.TestNamespace}}
spec:
host: {{.Host}}
pathPrefixes:
- {{.PathPrefix0}}
- {{.PathPrefix1}}
- {{.PathPrefix2}}
targetPendingRequests: 100
scaledownPeriod: 10
scaleTargetRef:
deployment: {{.DeploymentName}}
service: {{.ServiceName}}
deployment: {{.DeploymentName}}-2
service: {{.ServiceName}}-2
port: 8080
replicas:
min: {{ .MinReplicas }}
max: {{ .MaxReplicas }}
`

loadJobTemplate = `
apiVersion: batch/v1
kind: Job
metadata:
name: generate-request
namespace: {{.TestNamespace}}
spec:
template:
spec:
containers:
- name: curl-client
image: curlimages/curl
imagePullPolicy: Always
command: ["curl", "-H", "Host: {{.Host}}", "keda-http-add-on-interceptor-proxy.keda:8080{{.PathPrefix}}"]
restartPolicy: Never
activeDeadlineSeconds: 600
backoffLimit: 5
`
)

func TestCheck(t *testing.T) {
Expand All @@ -144,57 +220,72 @@ func TestCheck(t *testing.T) {
// Create kubernetes resources
kc := GetKubernetesClient(t)
data, templates := getTemplateData()
CreateKubernetesResources(t, kc, testNamespace, data, templates)
CreateNamespace(t, kc, testNamespace)

assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minute", minReplicaCount)

testScale(t, kc, data, templates, pathPrefix0)
t.Log("--- testing scale of workload1 with prefix0 ---")
testScale(t, kc, data, templates, deploymentName, deploymentName2, pathPrefix0)
t.Log("--- testing not scale ---")
testNotScale(t, kc, data, templates, notPathPrefix0)
testScale(t, kc, data, templates, pathPrefix1)
t.Log("--- testing scale of workload1 with prefix1 ---")
testScale(t, kc, data, templates, deploymentName, deploymentName2, pathPrefix1)
t.Log("--- testing not scale ---")
testNotScale(t, kc, data, templates, notPathPrefix1)
t.Log("--- testing scale of workload2 with prefix2 ---")
testScale(t, kc, data, templates, deploymentName2, deploymentName, pathPrefix2)

// cleanup
DeleteNamespace(t, testNamespace)
}

func testScale(t *testing.T, kc *kubernetes.Clientset, data templateData, templates []Template, pathPrefix string) {
t.Log("--- testing scale ---")

func testScale(t *testing.T, kc *kubernetes.Clientset, data templateData, templates []Template, scaledWorkload, notScaledWorkload, pathPrefix string) {
// create resources
KubectlApplyMultipleWithTemplate(t, data, templates)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, minReplicaCount, 6, 10),
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, scaledWorkload, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minute", minReplicaCount)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, notScaledWorkload, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minute", minReplicaCount)

data.PathPrefix = pathPrefix

// scale in
KubectlApplyWithTemplate(t, data, "loadJobTemplate", loadJobTemplate)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, maxReplicaCount, 6, 10),
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, scaledWorkload, testNamespace, maxReplicaCount, 6, 10),
"replica count should be %d after 1 minute", maxReplicaCount)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, notScaledWorkload, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minute", minReplicaCount)

// scale out
KubectlDeleteWithTemplate(t, data, "loadJobTemplate", loadJobTemplate)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, minReplicaCount, 12, 10),
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, scaledWorkload, testNamespace, minReplicaCount, 12, 10),
"replica count should be %d after 2 minutes", minReplicaCount)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, notScaledWorkload, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minute", minReplicaCount)

// cleanup
KubectlDeleteMultipleWithTemplate(t, data, templates)
}

func testNotScale(t *testing.T, kc *kubernetes.Clientset, data templateData, templates []Template, pathPrefix string) {
t.Log("--- testing not scale ---")

// create resources
KubectlApplyMultipleWithTemplate(t, data, templates)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minutes", minReplicaCount)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName2, testNamespace, minReplicaCount, 6, 10),
"replica count should be %d after 1 minutes", minReplicaCount)

data.PathPrefix = pathPrefix

// not scale
KubectlApplyWithTemplate(t, data, "loadJobTemplate", loadJobTemplate)
AssertReplicaCountNotChangeDuringTimePeriod(t, kc, deploymentName, testNamespace, minReplicaCount, 2*60)
assertion := func(workload string, waitGroup *sync.WaitGroup) {
AssertReplicaCountNotChangeDuringTimePeriod(t, kc, workload, testNamespace, minReplicaCount, 60)
waitGroup.Done()
}
wg := sync.WaitGroup{}
wg.Add(2)
go assertion(deploymentName, &wg)
go assertion(deploymentName2, &wg)
wg.Wait()

// cleanup
template := Template{Name: "loadJobTemplate", Config: loadJobTemplate}
Expand All @@ -210,11 +301,15 @@ func getTemplateData() (templateData, []Template) {
Host: host,
PathPrefix0: pathPrefix0,
PathPrefix1: pathPrefix1,
PathPrefix2: pathPrefix2,
MinReplicas: minReplicaCount,
MaxReplicas: maxReplicaCount,
}, []Template{
{Name: "deploymentTemplate", Config: deploymentTemplate},
{Name: "serviceNameTemplate", Config: serviceTemplate},
{Name: "httpScaledObjectTemplate", Config: httpScaledObjectTemplate},
{Name: "deploymentTemplate2", Config: deploymentTemplate2},
{Name: "serviceNameTemplate2", Config: serviceTemplate2},
{Name: "httpScaledObjectTemplate2", Config: httpScaledObjectTemplate2},
}
}
Loading