Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Grab, a new KEDA user! #1231

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Welcome Grab, a new KEDA user! #1231

merged 1 commit into from
Sep 26, 2023

Conversation

CtrlAltDft
Copy link
Contributor

Signed off by Karan Kamath - [email protected]

FYI @dttung2905

@CtrlAltDft CtrlAltDft requested a review from a team as a code owner September 26, 2023 05:02
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 4e67c9a
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65128d9f25823f0008b6681c
😎 Deploy Preview https://deploy-preview-1231--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@dttung2905
Copy link
Contributor

@zroubalik This is what I mentioned about the other day. Could you help to review it ?

Thanks Thang for helping with the PR 😜

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using KEDA!

Can you fix the DCO issues please? You can learn more in our contribution guide.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using KEDA!

Can you fix the DCO issues please? You can learn more in our contribution guide.

@JorTurFer
Copy link
Member

You can see the steps to fix DCO in the check link:
image

image

@CtrlAltDft
Copy link
Contributor Author

Thank you both for the guidance 🙏 I have fixed the DCO check. There is one last required check that has been stuck for quite some time Mixed content - keda, is there anything I can do to fix it?

@zroubalik
Copy link
Member

@zroubalik This is what I mentioned about the other day. Could you help to review it ?

Thanks Thang for helping with the PR 😜

Awesome! 🚀

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@zroubalik
Copy link
Member

Thank you both for the guidance 🙏 I have fixed the DCO check. There is one last required check that has been stuck for quite some time Mixed content - keda, is there anything I can do to fix it?

Ignore it :)

@zroubalik zroubalik merged commit 871d978 into kedacore:main Sep 26, 2023
7 checks passed
@CtrlAltDft
Copy link
Contributor Author

Thank you :)

@JorTurFer
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants