Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add databaseIndex to documentation of redis-cluster scaler #1234

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

peschmae
Copy link
Contributor

@peschmae peschmae commented Oct 1, 2023

Provide a description of what has been changed

Add databaseIndex argument to documentation of redis-cluster scaler.
The text is identical to the redis scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@peschmae peschmae requested a review from a team as a code owner October 1, 2023 12:31
@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 294c421
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/651faa1a5809a20008032eac
😎 Deploy Preview https://deploy-preview-1234--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@JorTurFer
Copy link
Member

Nice!
You're right, all the redis list/stream scalers use the same library under the hood, so the behaviour should be the same. Could you update other redis docs with this change too?

@peschmae
Copy link
Contributor Author

peschmae commented Oct 6, 2023

I just realised that there are mutliple version directories for the docs.
I've updated 2.12 in the previous commit. Should I also do 2.13 or are some changes synced between the versions?

@peschmae
Copy link
Contributor Author

peschmae commented Oct 6, 2023

I've squashed all doc changes for 2.12 into a single commit, and made the same changes to the docs for 2.13.

I hope it's fine like this

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the improvement ❤️

@JorTurFer JorTurFer merged commit a9520a2 into kedacore:main Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants