Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add doc for hashicorp vault secret mode and data #1242

Merged
merged 3 commits into from
Oct 13, 2023
Merged

feat: add doc for hashicorp vault secret mode and data #1242

merged 3 commits into from
Oct 13, 2023

Conversation

loispostula
Copy link
Contributor

Provide description related with kedacore/keda#5067 and

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5067

@loispostula loispostula requested a review from a team as a code owner October 10, 2023 18:54
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 524f0bf
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65293b9f6febc000083b5cdb
😎 Deploy Preview https://deploy-preview-1242--keda.netlify.app/docs/2.13/authentication-providers/hashicorp-vault
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also adding a short example would be nice.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nit

@zroubalik zroubalik merged commit dfdde58 into kedacore:main Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashicorp Vault: Support for writable secret
2 participants