Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keda_scaled_object_paused to the docs #1249

Merged
merged 11 commits into from
Oct 30, 2023
Merged

add keda_scaled_object_paused to the docs #1249

merged 11 commits into from
Oct 30, 2023

Conversation

geoffrey1330
Copy link
Contributor

@geoffrey1330 geoffrey1330 commented Oct 16, 2023 •
edited
Loading

related to kedacore/keda#5045

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@geoffrey1330 geoffrey1330 requested a review from a team as a code owner October 16, 2023 09:59
@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 37d3f18
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/653f7fad5821bb0008671fd0
😎 Deploy Preview https://deploy-preview-1249--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@geoffrey1330 geoffrey1330 changed the title Feat/keda scaled object pause add keda_scaled_object_paused to the docs Oct 16, 2023
@geoffrey1330
Copy link
Contributor Author

@zroubalik from our conversation here #1111
Do you mean i should add opentelemetry docs in 2.11?

@zroubalik
Copy link
Member

@zroubalik from our conversation here #1111 Do you mean i should add opentelemetry docs in 2.11?

no, add opentelemetry docs and all docs should happen in 2.13, because that's the version we are going to ship the feature in.

@geoffrey1330
Copy link
Contributor Author

@zroubalik from our conversation here #1111 Do you mean i should add opentelemetry docs in 2.11?

no, add opentelemetry docs and all docs should happen in 2.13, because that's the version we are going to ship the feature in.

Alright Let me do that now.

@geoffrey1330
Copy link
Contributor Author

@zroubalik I have made the changes. could you please review.

zroubalik
zroubalik requested changes Oct 16, 2023
View reviewed changes
content/docs/2.13/operate/opentelemetry.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/prometheus.md Outdated Show resolved Hide resolved
content/docs/2.13/operate/opentelemetry.md Outdated Show resolved Hide resolved
content/docs/2.11/operate/prometheus.md Outdated Show resolved Hide resolved
geoffrey1330 and others added 4 commits October 16, 2023 16:14
@geoffrey1330 @zroubalik
Update content/docs/2.13/operate/opentelemetry.md
432c84f 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Geoffrey Israel <[email protected]>
@geoffrey1330 @zroubalik
Update content/docs/2.13/operate/prometheus.md
87e8e66 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Geoffrey Israel <[email protected]>
@geoffrey1330 @zroubalik
Update content/docs/2.13/operate/opentelemetry.md
a9cbf29 
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Geoffrey Israel <[email protected]>
@JorTurFer
Apply suggestions from code review
6776afb 
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@zroubalik zroubalik mentioned this pull request Oct 30, 2023
Closed
1 task
zroubalik
zroubalik requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

content/docs/2.13/operate/prometheus.md Outdated Show resolved Hide resolved
geoffrey1330 and others added 2 commits October 30, 2023 11:04
@geoffrey1330
Copy link
Contributor Author

@zroubalik I have made the suggested changes.
cc @JorTurFer

@zroubalik zroubalik merged commit c55b607 into kedacore:main Oct 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geoffrey1330 @zroubalik @JorTurFer @eladmotola