Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document topicName and aggregation in gcp-pubsub #1271

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

kevinmingtarja
Copy link
Contributor

Document the new topicName and aggregation parameter in gcp-pubsub scaler that is introduced in kedacore/keda#5246.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

@kevinmingtarja kevinmingtarja requested a review from a team as a code owner December 3, 2023 16:08
Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 7c9be45
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/656ca89379a0fe0009df474e
😎 Deploy Preview https://deploy-preview-1271--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 3, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@kevinmingtarja
Copy link
Contributor Author

kevinmingtarja commented Dec 3, 2023

For reviewers, the only page that is changed can be previewed at https://deploy-preview-1271--keda.netlify.app/docs/2.13/scalers/gcp-pub-sub!

@zroubalik zroubalik merged commit e0df472 into kedacore:main Dec 7, 2023
8 checks passed
@kevinmingtarja kevinmingtarja deleted the gcp-pubsub-enhancement branch December 7, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants