Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gcp-stackdriver): adding valueIfNull #1285

Merged
merged 1 commit into from
Jan 3, 2024
Merged

feat(gcp-stackdriver): adding valueIfNull #1285

merged 1 commit into from
Jan 3, 2024

Conversation

lindmin
Copy link
Contributor

@lindmin lindmin commented Jan 3, 2024 •
edited
Loading

Provide a description of what has been changed

Handling new metadata valueIfNull
kedacore/keda#5345

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@lindmin lindmin requested a review from a team as a code owner January 3, 2024 14:25
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0836dc1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65957b9d430b2f0008178963
😎 Deploy Preview https://deploy-preview-1285--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@lindmin lindmin mentioned this pull request Jan 3, 2024
Merged
6 tasks
JorTurFer
JorTurFer reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this will be included in v2.13, could you move this changes to that file instead of v2.12?

@JorTurFer JorTurFer merged commit d89d8f2 into kedacore:main Jan 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindmin @JorTurFer