Update ScaledJob scaling strategy section #1562
Open
+176
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rections for `eager` strategy Signed-off-by: Andrew Chinery <[email protected]>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Andrew Chinery <[email protected]>
zroubalik
reviewed
Apr 24, 2025
There was a problem hiding this comment.
Excellent, sorry for the delay, could you please also update the file in 2.18 (upcoming) version?
https://github.com/kedacore/keda-docs/tree/main/content/docs/2.18
Hi @zroubalik, so sorry for an even longer delay on my part (and for a simple request!). Have just updated the file in 2.18 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the scaling strategy section of the
ScaledJobspec, based on this issue and discussion on the community Zoom call.Summary of changes:
defaultshould work for most users (hopefully meaning they don't need to read this section at all!)eagersection to reflect the actual behaviour (as discussed in the issue linked above)With this PR, the documentation should correctly match the behaviour of KEDA 2.16, i.e. it does not include any of the minor changes I'm planning to make to the scaling strategy code, for which I'll make a separate docs PR (I've been busier than expected!).
Checklist