-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: external calculation via gRPC servers #4859
Conversation
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
…ne scaling logic for external calculator list Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
… scale_handler test one Signed-off-by: gauron99 <[email protected]>
…ation funcs Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
…anup Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
…dation Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
Any update on this? If we don't hear back in the near future we'd likely need to close this PR |
I have rebased part of what needs to be rebased. its not complete but more pressing issues were at hand. I was told its not exactly a wanted issue but would be nice to have ready. If youd like this to be implemented I can up the priority. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
STATUS
ready to be worked on prerequisite PR merged.
this PR is a follow up for this. Both of these are part of the Parent PR that Ive separated into 2 for easier and more clear reviews etc.
gRPC servers summary
this PR implements new way to manipulate/alter/ external metrics.
Each server has:
explanation
proto file exists in
pkg/externalscaling/api
which describes the structure of following generated KEDA client side for gRPC and is the base for the gRPC server that user can implement.If this server is implemented, structure in SO is defined and KEDA successfully connects - this feature implements possibility for user to use defined external triggers, send them to this server where they can manipulate them however they want and return whatever they want in the same structure. This structure is converted to the one KEDA uses (
[]external_metrics.ExternalMetricValue
) and simply returns the metrics, passing it to HPA. (possibly through formula and then passing it to HPA if defined)possible struct view in SO
struct name is to be determined
Checklist
Closes #4583