Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InitialCooldownPeriod from int32 to *int32 #6424

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Change InitialCooldownPeriod from int32 to *int32 #6424

merged 1 commit into from
Dec 16, 2024

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Dec 16, 2024 •
edited
Loading

  • Changing type, shouldn't be user affecting change
  • Updating zz_generated.deepcopy.go

Checklist

Fixes #6423

@zroubalik zroubalik requested a review from a team as a code owner December 16, 2024 14:17
@zroubalik
Copy link
Member Author

zroubalik commented Dec 16, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 99c3b9c into kedacore:main Dec 16, 2024
21 checks passed
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@zroubalik @chiragbhatia8
Change InitialCooldownPeriod from int32 to *int32 (kedacore#6424)
320d5b7 
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Chirag Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InitialCooldownPeriod should be *int32 not int32
3 participants
@zroubalik @wozniakjan @JorTurFer