Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct warning event text format when deactivation fails #6469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct warning event text format when deactivation fails #6469

wants to merge 1 commit into from

Conversation

wozniakjan
Copy link
Member

The format message is missing two verbs (or has two extra arguments) resulting in slightly broken event text

  Warning  KEDAScaleTargetDeactivationFailed  8m14s                  keda-operator            Failed to deactivated apps/v1.Deployment default/http-server%!(EXTRA int32=1, int32=0)

Checklist

@wozniakjan wozniakjan requested a review from a team as a code owner January 8, 2025 15:48
@wozniakjan
Copy link
Member Author

wozniakjan commented Jan 8, 2025 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@wozniakjan wozniakjan force-pushed the chore/fix_event_text_when_deactivation_fails branch from 48f2749 to 57e0b80 Compare January 9, 2025 07:50
@wozniakjan
Copy link
Member Author

wozniakjan commented Jan 9, 2025 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@wozniakjan wozniakjan force-pushed the chore/fix_event_text_when_deactivation_fails branch from 57e0b80 to 2c5fe38 Compare January 9, 2025 08:13
@wozniakjan
Copy link
Member Author

wozniakjan commented Jan 9, 2025 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) January 9, 2025 09:00
@wozniakjan wozniakjan changed the title chore: fix event text when deactivation fails fix: correct warning event text format when deactivation fails Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wozniakjan @zroubalik