Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent v0.1.4 release + better defaults #66

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

wozniakjan
Copy link
Member

No description provided.

@wozniakjan wozniakjan requested a review from a team November 12, 2024 17:19
@wozniakjan wozniakjan force-pushed the defaults_and_0.1.4_agent_release branch from b0181dd to 77a4cc3 Compare November 12, 2024 17:22
@@ -45,7 +45,7 @@ logging:
# operator-specific configuration values
operator:
# -- Number of replicas, oerator k8s resources will not be installed if this is set to 0
replicas: 1
replicas: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the kedify-http scaler no longer uses addon operator

@@ -14,21 +14,21 @@ image:
# -- Image name of KEDA operator
repository: kedacore/keda
# -- Image tag of KEDA operator. Optional, given app version of Helm chart is used by default
tag: ""
tag: "v2.16.0-1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this is now a kedify-agent subchart, we should start setting these

@wozniakjan wozniakjan force-pushed the defaults_and_0.1.4_agent_release branch from 77a4cc3 to f1739f9 Compare November 12, 2024 17:28
@jkremser
Copy link
Member

There are some failed tests, though. ImgPullBackoff... probably wrong image

Signed-off-by: Jan Wozniak <[email protected]>
@wozniakjan wozniakjan force-pushed the defaults_and_0.1.4_agent_release branch from 1c4b6e4 to eda2b54 Compare November 13, 2024 08:07
@wozniakjan
Copy link
Member Author

There are some failed tests, though. ImgPullBackoff... probably wrong image

looks like in the tests here, we never actually tested kedify images but it was still on kedacore...

@wozniakjan wozniakjan merged commit 725454c into kedify:main Nov 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants