-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate starter template docs from recommonmark to myst_parser #1503
Migrate starter template docs from recommonmark to myst_parser #1503
Conversation
Signed-off-by: Avaneesh Yembadi <[email protected]>
Signed-off-by: Avaneesh Yembadi <[email protected]>
Signed-off-by: Avaneesh Yembadi <[email protected]>
Signed-off-by: Avaneesh Yembadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice! I was just saying to @MerelTheisenQB yesterday that we should make this change but might not get around to it since probably we should reconsider the whole kedro build-docs
command, whether to continue using sphinx, update other bits in conf.py because it's very old...
Anyway, this definitely seems like a good improvement to the current setup, thank you! Please can you add a note to RELEASE.md and also make the change to kedro-starters?
@AntonyMilneQB Is this just about how docs are built within a kedro project? If this is already on cards, this change might not be worth it as introducing two breaking changes in succession might not be worth it. I could also take a crack at the refactor/clean-up if you could elaborate a bit on what/why we're looking to do. |
@avan-sh Yeah, this is just about how docs are build within a kedro project. I'd say that future changes are not imminently on the cards, so I think it's still worth making this change now. Given that this change doesn't actually touch the Equally you could argue that the number of affected users is so small that it's just not worth the bother of updating it, since no one has noticed that the project template uses an old sphinx extension...
Thank you for the offer but I think it's a bit premature to actually do anything about this because we haven't at all worked out what to do with it yet 😅 I was just mentioning it as a vague future plan - we still need to check telemetry data, do user research, etc. Probably needs to be considered as part of the whole vaguely-planned streamlining of the CLI and #1293. |
👍
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @avan-sh ! ⭐ 👍
Signed-off-by: Avaneesh Yembadi <[email protected]>
Description
PR #1489 addresses the bulk of the changes required for migrating to myst-parser in docs, this pr modifies
conf.py
in templates which is used bykedro build-docs
command in new projects.Closes #1479
Note: While this is likely to not be breaking for new projects, docs copied directly from older projects might need to be updated.
Development notes
docs/conf.py
&setup.py
to remove references torecommonmark
and update it tomyst_parser
.kedro build docs
.Checklist
RELEASE.md
file