-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog2.0]: Move pattern resolution logic - catalog cli #4130
Closed
ElenaKhaustova
wants to merge
15
commits into
4110-move-pattern-resolution-logic-project-cli
from
4110-move-pattern-resolution-logic-catalog-cli
Closed
[DataCatalog2.0]: Move pattern resolution logic - catalog cli #4130
ElenaKhaustova
wants to merge
15
commits into
4110-move-pattern-resolution-logic-project-cli
from
4110-move-pattern-resolution-logic-catalog-cli
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
…10-move-pattern-resolution-logic-catalog-cli
…10-move-pattern-resolution-logic-catalog-cli
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
changed the title
Move pattern resolution logic catalog cli
[DataCatalog2.0]: Move pattern resolution logic - catalog cli
Aug 29, 2024
This was referenced Aug 29, 2024
ElenaKhaustova
requested review from
astrojuanlu,
idanov,
noklam,
DimedS,
lrcouto and
ankatiyar
August 29, 2024 22:09
…10-move-pattern-resolution-logic-catalog-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of #4110 and is done on top of #4124
It serves as an example of changes required to keep both implementations together so that users can switch between them and use both, see the related comment
For the reviewers: this PR does not include tests, please see the suggested order of work in this comment
Development notes
This PR includes modification of
kedro catalog
commands -list
,create
,rank
andresolve
to be compatible withKedroDataCatalog
andDataCatalogConfigResolver
.Currently, one can use old
DataCatalog
as usual without any changes or useKedroDataCatalog
withkedro catalog [command]
by adding--new_catalog
or-n
flag:Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file