-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog]: Lazy dataset loading #4270
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
7c794f4
Move warm-up to runner
ElenaKhaustova 208a24b
Implemented test for running thread runner with patterns
ElenaKhaustova 7c6729a
Added test for new catalog
ElenaKhaustova 9d5b37d
Add line separator to file
ElenaKhaustova c3229c0
Replaced writing csv manually to writing with pandas
ElenaKhaustova 6c509d9
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova bd878c9
Fixed fixture
ElenaKhaustova 68010aa
Removed new catalog from test
ElenaKhaustova 29d373f
Made catalog type a parameter
ElenaKhaustova e90cfd7
Removed old catalog from test
ElenaKhaustova 3f1dbe0
Removed new catalog from test
ElenaKhaustova 892cda4
Removed data creation/loading
ElenaKhaustova e7f2632
Fixed test docstring
ElenaKhaustova 429ca13
Removed extra loop
ElenaKhaustova 3ffd538
Renamed variable for clarifty
ElenaKhaustova 681d3f1
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova 8177ddc
Replaced ald method in the constructor
ElenaKhaustova 379f3b4
Implemented dataset materialization
ElenaKhaustova 9335578
Added temporal repr
ElenaKhaustova 26d0c84
Removed replacing warning when init
ElenaKhaustova dea5630
Improved repr
ElenaKhaustova 0da806f
Fixed bug in get()
ElenaKhaustova b813408
Merge branch 'fix/4250-move-warm-up-to-runner' into feature/3935-lazy…
ElenaKhaustova c63ece6
Moved warm-up to the top
ElenaKhaustova 01f9b62
Moved warm-up to the top
ElenaKhaustova 069dff4
Moved warm-up to the top
ElenaKhaustova 15df0f8
Merge branch 'fix/4250-move-warm-up-to-runner' into feature/3935-lazy…
ElenaKhaustova da669f5
Updated eq and repr
ElenaKhaustova 3999913
Fixed mypy errors
ElenaKhaustova c50cad4
Removed brackets from repr
ElenaKhaustova f2861ed
Renamed non_initialized to lazy
ElenaKhaustova df5807c
Fixed bug in the constructor
ElenaKhaustova eecf23a
Made the iteration order fixed
ElenaKhaustova 128e79c
Fixed unit tests
ElenaKhaustova 3b475aa
Added test for repr
ElenaKhaustova 32dc417
Merge branch 'main' into feature/3935-lazy-loading
ElenaKhaustova 72c106b
Merge branch 'main' into feature/3935-lazy-loading
ElenaKhaustova 870b794
Added docstrings
ElenaKhaustova e031f8a
Updated release notes
ElenaKhaustova 9d0f579
Merge branch 'main' into fix/4250-move-warm-up-to-runner
ElenaKhaustova 5f6ef85
Updated release notes
ElenaKhaustova 6d23b4d
Merge branch 'fix/4250-move-warm-up-to-runner' into feature/3935-lazy…
ElenaKhaustova c31c5eb
Renamed variable for consistency
ElenaKhaustova 822e206
Updated release notes
ElenaKhaustova 1f14ded
Merge branch 'main' into feature/3935-lazy-loading
ElenaKhaustova 25aebce
Merge branch 'main' into feature/3935-lazy-loading
ElenaKhaustova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we'd like to expose
_LazyDataset
to the users? If yes, then maybe we need to make it a properLazyDataset
that can be instantiated even outside of the catalog. Otherwise, I'd prefer for us to hide it from this method signature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to expose it and we added it here only until we use the old
add()
method for compatibility with the old catalog. I will go after the breaking change as setter will be used instead.